ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Fix broken activity delete action, hide discussion on empty progress page #800

Closed MiroDojkic closed 3 years ago

MiroDojkic commented 3 years ago

This PR:

⚠️ Issue was caused by Sequelize's individualHooks flag in the model methods. When used, it loads instances with the appropriate scopes before running the update query. In this case, it caused the bug which would assign included model's alias (from the default scope) to update query's column.

:mag: QA note:

This change affects functionalities that save data to the server (creating and updating elements, repositories, etc.)

kjuej commented 3 years ago

@MiroDojkic @underscope Seems to be functioning as expected!