ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Disable adding repository with an already used name #805

Closed bubafinder closed 3 years ago

bubafinder commented 3 years ago

I'm submitting a...

Context

  1. Go to the Catalog page
  2. Try to add the repository with an already used name

The user can add the repository with an already used name. Introduce a warning message to the User that a Course with that name already exists.

image

underscope commented 3 years ago

Changing the label since it is intended behavior rather than an issue. Let's chat about it.

bubafinder commented 3 years ago

Adding @Amer21214 to the discussion.

Amer21214 commented 3 years ago

If we will allow new Courses to be created with the name of a pre-existing Course, I really do suggest we introduce a warning message/validation to the User that a Course with that name already exists. The benefit of this action is worth the minor amount of work needed to implement specified behavior.

lukasaric commented 3 years ago

@markolovric @Amer21214 Should we display warning message on repository (course) settings details while user is editing repo name?

Amer21214 commented 3 years ago

@malizeus - place it right underneath the repository name field, please.

underscope commented 3 years ago

@markolovric @Amer21214 Should this happen when the user does not see an existing repository (with the same name; due to not having access to it). Will it be confusing? 🤔

bubafinder commented 3 years ago

I think it should not be confusing. The user needs to know that there is a repository with a duplicate name. Also, I requested Luka to skip soft-deleted repositories.

Amer21214 commented 3 years ago

@underscope I wasn't aware that there could be courses visible to one User and not to another User. The underlying goal here is to avoid having any User see 2 Courses with the same name. This, for instance, includes the case where any "sub-User" creates a Course with a name that exists in the Course List of another sub-User, but both Courses would be visible in the list to an Admin/Instructor.