ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Allow storage proxy to work with IPv4 #893

Open droguljic opened 3 years ago

droguljic commented 3 years ago

Storage proxy signed cookies would get assigned to wrong domain if configured host name is IPv4 address, thus blocking display of assets. Problem is in psl package which parses IPv4 addresses, thus producing wrong domains. Fix detects IPv4 addresses using regular expression and just returns null for domain.

underscope commented 3 years ago

@droguljic Please base this on release/5.0 😉 Thx!