On the video, you can see that visiting a subroute (clicking on People, thus going to /settings/users) will remove the highlight from Settings, since Structure has become active. The proposed fix seems to enforce the exact-path match, thus recently active (Settings tab) remains active. This is because repository route wasn't matched exactly.
underscope
commented
2 years ago
This PR introduces a visual fix for the bug captured in the video below:
https://user-images.githubusercontent.com/6833568/178470607-941baf5f-72d6-4765-9aa1-9255493150fe.mov
On the video, you can see that visiting a subroute (clicking on
People, thus going to/settings/users) will remove the highlight fromSettings, sinceStructurehas become active. The proposed fix seems to enforce the exact-path match, thus recently active (Settingstab) remains active. This is becauserepositoryroute wasn't matched exactly.