search

ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Fix footer's vertical alignment #988

Closed marjev closed 2 years ago

marjev commented 2 years ago

This PR fixes the vertical alignment within the footer found on Repository settings page (among other places).

The reason why this is broken lies in the fact that the row is flexbox container, but column is not, thus, flexbox alignment properties (attributes) aren't working as expected.

This is how it currently looks on develop: Screenshot 2022-07-13 at 09 41 06

This fix achieves the following effect: Screenshot 2022-07-13 at 09 42 14

which is closer to the screenshot which can be found in documentation: https://docs.google.com/document/d/1TuMm4qektujv6kweFcgffFVjI4ogWXTbJXY70Sh9G34/edit#heading=h.j1odoclusuqy

underscope commented 2 years ago

@marjev The only thing I noticed is that ❤️ is now a bit closer/too close to letters. Consider adding mx-1 to the icon 😉 Thanks!

marjev commented 2 years ago

@underscope comment addressed in 492536b

underscope commented 2 years ago

Thanks!