Gnome 45 port - Githubissues

Extensions-Valhalla / gnome-bluetooth-quick-connect

Allow to connect bluetooth paired devices from gnome control panel.

https://extensions.gnome.org/extension/1401/bluetooth-quick-connect/

GNU General Public License v3.0

31 stars 4 forks source link

Gnome 45 port #1

Closed BlankParticle closed 11 months ago

BlankParticle commented 11 months ago

This PR would be merged once we get some more testing done.

TODO List

[x] feat: Use ESM imports
[x] ~fix: Doesn't check if bluetoothctl is available before trying to connect to a device, thus gets stuck in Wait state~
[x] fix: Respect Debug Settings while logging
[x] feat: Drop Legacy Bluetooth Support as all changes are non backwards compatible
[x] fix: Device list doesn't update immediately after a devices is removed from paired devices
[x] feat: Use built-in methods in favour of removing power.js and bluetoothctl dependency

BlankParticle commented 11 months ago

@ionutbortis, as said by people on Gnome Matrix Server, we may need to publish a fork with new uuid, what uuid do you want?

Edit: I am using bluetooth-quick-connect@extensions.valhalla.gmail.com, we can change it later if you want

ionutbortis commented 11 months ago

@ionutbortis, as said by people on Gnome Matrix Server, we may need to publish a fork with new uuid, what uuid do you want?

Edit: I am using bluetooth-quick-connect@extensions.valhalla.gmail.com, we can change it later if you want

The new UUID is fine by me. I'm trying now to send an email to bjarosze@gmail.com, hopefully we'll get a reply. So I would wait a couple of days until submitting a different extension to ego. I'm also trying to reach him via linkedin but I need to wait for connection approval since we're not directly connected.

What do you think? Even if get a reply sometime, we could inactivate the new extension and just maintain the current one, I guess.

BlankParticle commented 11 months ago

I am making a clean up commit with the new UUID and formatting changes, if we can contact him I will revert the UUID change

BlankParticle commented 11 months ago

We got contacted with the original dev, he agreed to transfer ownership on EGO, but he archived his repo with a mention to our fork. I have reverted the UUID change and we can merge this PR once we get the ownership and get the extension reviewed.

Edit: We have ego ownership now Edit: Submitted Extension for review

BlankParticle commented 11 months ago

New Version published on EGO! :tada: Merging the PR

ionutbortis commented 11 months ago

Awesome work!