ExterminatorX99 / MagicStorageExtra

A tModLoader mod for Terraria
MIT License
10 stars 8 forks source link

Instability/Corruption/Crashes? The mod corrupts/breaks itself. #78

Open archynoid opened 2 years ago

archynoid commented 2 years ago

Hi I would like to report an issue with this mod. I've been doing some testing for the last hour looking into this and found that MagicStorageExtra breaks whenever enabling any other mod that isn't just client side.

https://i.imgur.com/nSCdRLi.png By itself and cheatsheet (for testing) See ^1 for more info.

https://i.imgur.com/hqq10Wi.png Alongside normal MagicStorage mod

https://i.imgur.com/Hd7ykFi.png Alongside JoJoStands mod

https://i.imgur.com/R27fYIa.png Alongside Calamity mod

Ignoring this bug and placing it in the world leads to more issues along the road as well. Interacting with it has a high chance to just straight up crash you. Using an upgrade on it spawns 999 of the upgraded version just before crashing you. Taking stuff out or putting stuff in the storage heart connected to it crashes you as well. I love the mod and have used it religiously but coming back to it after a break of modded Terraria is a bit unfortunate but I feel like we can get to the bottom of this.

It seems to be ONLY with the storage units as far as I can tell, this bug occurs whether you place down a storage unit or even if you upgrade it. This does NOT seem to occur at all in the standard version of Magic Storage

^1: Just tested it further and this bug also occurs by itself after disabling all other mods. https://i.imgur.com/BInHxvP.png It seems to be something along the lines of the first time it is used in a world it seems okay for the most part but if you save and exit the world it corrupts itself and starts performing this bug as seen above? Very lost on this

I am going to keep this here but close it, it seems something odd is occurring between the installation and activation of the jojostands mod alongside MagicStorageExtra. It still has issues even after you disable the jojostands mod so I am keeping it here for reference.

Scratch that it is not Jojostands, I keep testing with the bug more and more but I REALLY don't think it is on JojoStands side or if it is, then it's on both mods. there is some conflict between them, but I can't seem to figure out what it is the only thing I know is that it is only affecting the storage units.

archynoid commented 2 years ago

Duplicate of #65 It seems that there was more to it than meets the eye.

ExterminatorX99 commented 2 years ago

If you leave JoJoStands disabled the entire time, does this issue still happen?

archynoid commented 2 years ago

Yes, the problem lies in MSE.

ExterminatorX99 commented 2 years ago

Please send the client log

ghost commented 2 years ago

Not sure I understand what the bug is, but I have never encountered this issue. I use Calamity all the time. I don't use JoJoStands mod, so perhaps an issue on that mod? This is probably a mod conflict on their end.

lfjunionello commented 2 years ago

I also ran into this problem. Using tmodloader 64bit on multiplayer. Using Calamity + JoJoStands + StarsAbove, among other minor mods.