search

Externalizable / bongo.cat

Hit the bongos like Bongo Cat!
https://bongo.cat
MIT License
3.21k stars 423 forks source link

Nothing works on non-Latin keyboard layouts #146

Open grishka opened 3 years ago

grishka commented 3 years ago

Steps to reproduce:

  1. Switch to Russian keyboard layout
  2. Try pressing some keys
  3. Nothing happens

You shouldn't be using characters typed by keys unless you're accepting text input. Key codes correspond one-to-one to physical keys on the keyboard; characters do not, they're mapped by the operating system depending on user preferences.

Use this tool to see for yourself: event.key you're using changes depending on the active layout, but the numeric key code in event.which stays the same.

Externalizable commented 3 years ago

Great catch! Accepting Pull Requests for this, otherwise I'll get around to fixing this.