search

Externalizable / bongo.cat

Hit the bongos like Bongo Cat!
https://bongo.cat
MIT License
3.23k stars 425 forks source link

Bugfix to allow playing 2 different samples which map to the same value in KeyEnum #286

Closed DeannaGelbart closed 2 weeks ago

DeannaGelbart commented 3 years ago

This bugfix allows playing e.g. the first bongo (A key) and the first piano key (1 key) at the same time. Previously you could only play one or the other at a time because they map to the same value in KeyEnum.

DeannaGelbart commented 3 years ago

Oh, there is already a PR for this

DeannaGelbart commented 3 years ago

I closed this because I thought it duplicated another open PR, but later looking at the diffs I saw I took a different approach (changing the pressed array to store a tag while the other PR removes the pressed array). So I'm re-opening it.

DeannaGelbart commented 3 years ago

Link to the other PR https://github.com/Externalizable/bongo.cat/pull/286/files