Externalizable / bongo.cat

Hit the bongos like Bongo Cat!
https://bongo.cat
MIT License
3.21k stars 423 forks source link

Added one piano keyboard scale #4

Closed guastallaigor closed 3 years ago

guastallaigor commented 5 years ago

Note: I did this only for fun. Accept this only if you really liked this feature, because I had to change some things a bid.

The major changes I did were for the keyboard in the computer could look like a piano keyboard (key positioning). To do that, I needed changed the keyboard keys for the Bongos and Cymbal mainly.

So now the new keys are: Bongo left: - Bongo right: = Cymbal: * Meow: Space (unchanged) Piano: ZSXDCVGBHNJM, Marimba: QW...P (unchanged)

Now "C" is the keyboard letter "Z", and "C#" is the keyboard letter "S", and so on, like a normal piano keyboard.

All the sounds were download at Freesound, so no copyright infringements here.

I also updated the instructions.

c4l1c0 commented 5 years ago

why not do the same thing for marimba? q2w3er5t6y7u and so on. if he merge this i will do the marimba.

RafaelCamarda commented 5 years ago

Amazing man, thx!

Externalizable commented 3 years ago

Sorry about the long wait! I'm doing some early spring cleaning and felt the need to finally address this Pull Request, which has accumulated a lot of merge conflicts over the years, primarily because of 101823eea9a2656c6599fa9b3d64568eb9068cc4. That's my bad.

This issue outlines a better solution as I don't want to move the bongo keys around anymore: #135