Add setting to enable placing in inventory when punched

Extex101 / motorbike

Motorbike mod for Minetest

Other

4 stars 8 forks source link

Add setting to enable placing in inventory when punched #6

Closed AntumDeluge closed 3 years ago

AntumDeluge commented 3 years ago

Adds setting motorbike.punch_inv:

if enabled, bike is placed directly into inventory when punched
default: disabled

Extex101 commented 3 years ago

Good change, but instead of the settings.lua please add it to settings object in the init.lua

AntumDeluge commented 3 years ago

Okay, I'll get it done & update pull request.

AntumDeluge commented 3 years ago

Done. And I added the other settings to settingtypes.txt.

AntumDeluge commented 3 years ago

Might want to make sure that I got all the types correct in settingtypes.txt. Wasn't sure if max_speed, max_reverse, braking, & crumbly_spd were int types, so I used float to be safe (not that it would affect anything negatively as the two types are the same thing in Lua as I understand it).

Extex101 commented 3 years ago

👍 You want to make the setting on by default too? Then I'll quash-merge

AntumDeluge commented 3 years ago

You want to make the setting on by default too?

Is that what you want? I had it off to keep the original behavior by default.

AntumDeluge commented 3 years ago

Done.