ExtraJuiceMan / ChristWareAmongUs

A cheat for the recently popular fad game Among Us
MIT License
110 stars 33 forks source link

Only renders radar if the user is in a game #20

Closed mlucap closed 1 year ago

mlucap commented 4 years ago

While in the lobby or title screen, show a gui with the title, "Not in game"

https://i.imgur.com/gxTLopl.png

v0idp commented 4 years ago

I already fixed this in my commit with the update. I would also avoid unnecessary text output on the screen

mlucap commented 4 years ago

This doesn't "fix" anything, it just prevents radar from showing up while not in game. I do see why the text may be unnecessary but users may not know why radar isn't showing up and just prevents issues from being made that aren't there. I can remove the else statement to prevent the unnecessary text if needed though.

v0idp commented 4 years ago

yea I don't mind too much, It's an UX thing anyways. the radar will work just fine ingame which is okay. most hacks I see do it this way with an empty radar. because the UI doesn't represent the functionality itself and you maybe want to set the radar position in the main menu and not ingame when it already started. things like these. but that's a preference thing in UX anyways. Nothing to bother honestly. the crashing is gone that was important. I appreciate your input on this tho. UX is a topic we could talk for the next 100 years about.

mlucap commented 4 years ago

Ah I see, I saw a comment about "if (IsInGame ()) to the beginning of the "RenderRadar" function" and made the PR if that wanted to be implemented.

v0idp commented 1 year ago

@mlucap if you're looking for a more updated version check out my organization