Initial LES building block with Vreman's model

timofeymukha commented 7 months ago

This adds some types for LES.

A BAC les_model.
A concrete model in vreman_t. Implemented only on the CPU.
A simcomp, les_simcomp that drives the computation using a polymorphic les_model object.

The configuration looks something line

    {
      "type": "les_model",
      "model": "vreman",
      "c": 0.07,
      "nut_field": "nut",
      "compute_control": "tsteps",
      "compute_value": 1
    }

So, viscosity is just put into some user-selectable field. It's not used in any way, we will need the stress formulation to actually use the model and see how to couple things in the best way. There is also a les_delta field put in the registry, which holds the length scale.

The main purpose of this PR is to get the boll rolling with LES and make it easier for others to contribute. This implementation needs to be double-checked, tested, ported to GPU, etc. Other models should perhaps be added. My hope is that this represents more processable tasks for those less experienced with the code. Plus it would be good with early feedback.

I would like to merge this in the spirit of CI, because I fear that otherwise merging all the components for WMLES / stress formulation will be hell in the end. As already mentioned, this code will not mess up any computations since the viscosity is not used in the governing equations.

njansson commented 7 months ago

Great Stuff!

Agree would be good to get this into the code, let it run in the CI while the missing features are added.

timofeymukha commented 6 months ago

@muenschm Just updated the code based on our discussion.

muenschm commented 6 months ago

Yes, great thanks! Von: Timofey Mukha @.> Gesendet: Donnerstag, 1. Februar 2024 10:22 An: ExtremeFLOW/neko @.> Cc: Münsch, Manuel @.>; Mention @.> Betreff: Re: [ExtremeFLOW/neko] Initial LES building block with Vreman's model (PR #1111)

@muenschmhttps://github.com/muenschm Just updated the code based on our discussion.

— Reply to this email directly, view it on GitHubhttps://github.com/ExtremeFLOW/neko/pull/1111#issuecomment-1920871268, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCKVMMWJ3T5EAVYXDJBOPO3YRNNCLAVCNFSM6AAAAABCEAMYV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQHA3TCMRWHA. You are receiving this because you were mentioned.Message ID: @.**@.>>

timofeymukha commented 6 months ago

Yes, great thanks! Von: Timofey Mukha @.> Gesendet: Donnerstag, 1. Februar 2024 10:22 An: ExtremeFLOW/neko @.> Cc: Münsch, Manuel @.>; Mention @.> Betreff: Re: [ExtremeFLOW/neko] Initial LES building block with Vreman's model (PR #1111) @muenschmhttps://github.com/muenschm Just updated the code based on our discussion. — Reply to this email directly, view it on GitHub<#1111 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCKVMMWJ3T5EAVYXDJBOPO3YRNNCLAVCNFSM6AAAAABCEAMYV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQHA3TCMRWHA. You are receiving this because you were mentioned.Message ID: @.**@.>>

If you leave an approving review (you have to go to "Files changed" in the top here), it will merge :-).

ExtremeFLOW / neko

Initial LES building block with Vreman's model #1111