search

ExtremeFLOW / neko

/ᐠ. ｡.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
159 stars 28 forks source link

Feature/variable dt #1148

Closed Shiyu-Sandy-Du closed 4 months ago

Shiyu-Sandy-Du commented 4 months ago

This PR is re-issued following PR #1013. The branch in PR #1013 is too old and hence full of conflicts. This branch is built on most up-to-date develop-branch. In this branch, two things are modified:

  1. variable time stepping uses a running average instead of an arithmetic average (to cope with sudden explosion of the cfl number)
  2. lag fields are promoted to _scheme type (not just for pnpn)

Special acknowledge to @adperezm for setting up the architecture in PR#1013.

Shiyu-Sandy-Du commented 4 months ago

restart is plausible but turns out to be wrong here. Work on time step info in chkp file is on-going.

timofeymukha commented 4 months ago

Please update case-file.md with the new options.

timfelle commented 4 months ago

It seems you are missing an update to the .depends, which is why the tests are failing.

Shiyu-Sandy-Du commented 4 months ago

It seems you are missing an update to the .depends, which is why the tests are failing.

Yes it's the issue. now it's fixed.

Shiyu-Sandy-Du commented 4 months ago

Please update case-file.md with the new options.

Done