Closed Shiyu-Sandy-Du closed 3 months ago
Is there any special reason for not restarting directly, but waiting 5 time steps?
I guess you want to wait to stabilize the simulation a bit before taking new snapshots. In fact i would perhaps even wait more than 5, but that should be tested (or even done adaptively)
Is there any special reason for not restarting directly, but waiting 5 time steps?
The reason is mentioned by @pschlatt1. And in my test, the simulation explodes when I restart the projection right after dt changes.
Now this branch is ready to be reviewed and merged
@Shiyu-Sandy-Du @MartinKarp , Should we include this in 0.8, or wait for 0.9?
@Shiyu-Sandy-Du @MartinKarp , Should we include this in 0.8, or wait for 0.9?
We could include this in 0.8, otherewise there is a bug when applying projection together with variable dt
@Shiyu-Sandy-Du @MartinKarp , Should we include this in 0.8, or wait for 0.9?
We could include this in 0.8, otherewise there is a bug when applying projection together with variable dt
Ok good, then we have to add it