ExtremeFLOW / neko

/ᐠ. 。.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
159 stars 28 forks source link

Projection #1174

Closed Shiyu-Sandy-Du closed 3 months ago

Shiyu-Sandy-Du commented 4 months ago
  1. Projection is accommodated for variable dt:
    • When dt changes, clear the projection space anddo not perform projection for the next 5 time steps
    • When projection space is empty, do not add the projection info into log file because at that time step, only proj_back is activated but info log recorded at proj_on
  2. Move dt_last_change into type time_step_controller
MartinKarp commented 4 months ago

Is there any special reason for not restarting directly, but waiting 5 time steps?

pschlatt1 commented 4 months ago

I guess you want to wait to stabilize the simulation a bit before taking new snapshots. In fact i would perhaps even wait more than 5, but that should be tested (or even done adaptively)

Shiyu-Sandy-Du commented 4 months ago

Is there any special reason for not restarting directly, but waiting 5 time steps?

The reason is mentioned by @pschlatt1. And in my test, the simulation explodes when I restart the projection right after dt changes.

Shiyu-Sandy-Du commented 3 months ago

Now this branch is ready to be reviewed and merged

njansson commented 3 months ago

@Shiyu-Sandy-Du @MartinKarp , Should we include this in 0.8, or wait for 0.9?

Shiyu-Sandy-Du commented 3 months ago

@Shiyu-Sandy-Du @MartinKarp , Should we include this in 0.8, or wait for 0.9?

We could include this in 0.8, otherewise there is a bug when applying projection together with variable dt

njansson commented 3 months ago

@Shiyu-Sandy-Du @MartinKarp , Should we include this in 0.8, or wait for 0.9?

We could include this in 0.8, otherewise there is a bug when applying projection together with variable dt

Ok good, then we have to add it