Modules masked by variables

timfelle commented 6 months ago

A number of variables are actually masking modules several places in the code. We discussed several approaches to solving it. One could be changing the naming convention of modules to have a "name_m" similar to what is established with types. Alternatively one could go and use other names for the variables. However it is no simple task. Here we can try to keep track of where we meet it to also have a checklist to resolve later.

[ ] case input variable in simulation component initializers are a good example of something with many side effects.

timofeymukha commented 1 week ago

We should bring up the discussion about the _m for modules. We kind of agreed on it, but scheduled for after 0.8, which is pretty much now. I am still very much in favour.

njansson commented 1 week ago

No, we didn't not agree :), Please no we should not append _m

timfelle commented 6 days ago

Well if we don't append the _m then we should start renaming the variables. So case could be neko_case maybe?

MartinKarp commented 6 days ago

Im not sure I am clear on the effects of this. How does for example calling variable case make things problematic?

ExtremeFLOW / neko

Modules masked by variables #1193