ExtremeFLOW / neko

/ᐠ. 。.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
166 stars 30 forks source link

debug on projection #1198

Closed Shiyu-Sandy-Du closed 6 months ago

Shiyu-Sandy-Du commented 6 months ago

debug projection to make simulation work without projection and remove some dummy stuffs

timofeymukha commented 6 months ago

A little bit sad to have the ifs back in the fluid step. Would it be a good trick to init the projections with activ_step=huge(0) when the space size is 0, or something like that, so that they just effectively never run?

Shiyu-Sandy-Du commented 6 months ago

A little bit sad to have the ifs back in the fluid step. Would it be a good trick to init the projections with activ_step=huge(0) when the space size is 0, or something like that, so that they just effectively never run?

I have no idea, it sounds work, but those ifs are quite simple, right?

njansson commented 6 months ago

A little bit sad to have the ifs back in the fluid step. Would it be a good trick to init the projections with activ_step=huge(0) when the space size is 0, or something like that, so that they just effectively never run?

I have no idea, it sounds work, but those ifs are quite simple, right?

I tend to agree with @timofeymukha comments, nice to keep the step loop as clean as possible and hide the logic somewhere else ( if possible)

Shiyu-Sandy-Du commented 6 months ago

Ohhh actually we don't need to do anything, but remove the "if" in the constructor of objects. In pre and post-solving projection subroutine, all processing start only if this%L .gt. 0

njansson commented 6 months ago

We need to fix this to address currently failed CI runs