ExtremeFLOW / neko

/ᐠ. 。.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
166 stars 30 forks source link

More only statements #1226

Closed timofeymukha closed 5 months ago

timofeymukha commented 6 months ago

I avoided touching device related stuff here, because I compile for a CPU backend and some misses are only detected at link type. So those should be tackled in an upcoming sweep.

timofeymukha commented 6 months ago

Never seizes to amaze me how inconsistent things are across compilers :-)

timofeymukha commented 6 months ago

Not sure what the best way to deal with small modules, for example addingonly for gs_op.f90 is a bit overkill since the module only provides what we then add in the only statement.

Yeah, that's true. Still, I'd rather minimize Cray's warnings when possible :-). I guess there aren't many modules that fall into this category though.

njansson commented 5 months ago

Not sure what the best way to deal with small modules, for example addingonly for gs_op.f90 is a bit overkill since the module only provides what we then add in the only statement.

Yeah, that's true. Still, I'd rather minimize Cray's warnings when possible :-). I guess there aren't many modules that fall into this category though.

I've kind of admit defeat with recent Cray Fortran (some of these warnings can't be removed, e.g. things related to use mpi_f08 or iso_c_bindings sigh), and now use -M878,1753 to silence these warnings (^-^)v

(Ps. seems like only opens up other interesting way of breaking stuff, see for example https://github.com/ExtremeFLOW/neko/pull/1179)

timofeymukha commented 5 months ago

Not sure what the best way to deal with small modules, for example addingonly for gs_op.f90 is a bit overkill since the module only provides what we then add in the only statement.

Yeah, that's true. Still, I'd rather minimize Cray's warnings when possible :-). I guess there aren't many modules that fall into this category though.

I've kind of admit defeat with recent Cray Fortran (some of these warnings can't be removed, e.g. things related to use mpi_f08 or iso_c_bindings sigh), and now use -M878,1753 to silence these warnings (^-^)v

(Ps. seems like only opens up other interesting way of breaking stuff, see for example #1179)

Yeah, I saw that one, so I avoided comm here :-). I still think it's nice with only since one sees where stuff comes from, but as usual with Fortran there will be some exceptions to any rule.

timofeymukha commented 5 months ago

Merge?