ExtremeFLOW / neko

/ᐠ. 。.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
158 stars 27 forks source link

Boundary condition type updates #1240

Closed timofeymukha closed 2 months ago

timofeymukha commented 2 months ago

This continues the series of PRs on cleaning up bc_t and descendants.

timofeymukha commented 2 months ago

A bit nitpick, but looks a bit strange that all bc's are calling init_base. Shouldn't the logic rather be init() in the type, and that init might call init() (can be call init_base) in the base type

So what I am aiming for eventually is that init is deferred in the base time and follows an abstract interface. Since you can't have a default implementation for a deferred routine, the name of the constructor for bc_t has to be called something else. We used init_base in a few hierarchies, so I picked it up here as well. So, then init will call init_base in the beginning to setup the base type. The deferred init is not quite there yet, but this PR is kind of prepping for that :-).

timofeymukha commented 2 months ago

@MartinKarp Whenever you have time :-). A new batch of updates is coming.