search

ExtremeFLOW / neko

/ᐠ. ｡.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
158 stars 27 forks source link

Expand ax_helm to allow a coupled compute #1252

Closed timofeymukha closed 1 month ago

timofeymukha commented 2 months ago

So here is an initial proposition for adding an interface to ax, which works on 3 vectors in a coupled manner. After our discussions, this follows the easiest path, which does not directly generalize to a different number of vectors, but perhaps this is OK for no to get the stress formulation in. The ax_helm factory now takes a parameter "formulation", which can be either "simple", meaning the simplified stress tensor, for "full", for the full tensor. Naturally, the existing fluid scheme only uses the simple one.

The idea with this PR is mainly to settling on how to introduce the coupled ax_helm, so that we can start putting in GPU kernels into develop.

timofeymukha commented 2 months ago

Is it possible to figure out what flint is complaining about?

timofeymukha commented 1 month ago

Nice, but can we find a better name instead of simple ?

I dodged this by changing the factory argument to a logical "full_formulation". So, assumes we have 2 options, but this PR kind of does it anyway.