search

ExtremeFLOW / neko

/ᐠ. ｡.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
158 stars 27 forks source link

Change strain rate to include the 1/2 factor #1253

Closed timofeymukha closed 2 months ago

timofeymukha commented 2 months ago

This changes the strain_rate operator to actually return the strain rate instead of its double (which I think I copied from Nek5000). The x2 convention is easy to forget about and now caused some issues with the implemention of models for the stress formulation branch.

On develop, the operator is not used.

timofeymukha commented 2 months ago

@Shiyu-Sandy-Du Please double check that the math is right now :-).

MartinKarp commented 2 months ago

I think it is used in the lift/drag, albeit as an input argument.

timofeymukha commented 2 months ago

I think it is used in the lift/drag, albeit as an input argument.

You are right, somehow my search missed that. I will take a look

Shiyu-Sandy-Du commented 2 months ago

The math is correct :D, and we need to change some stuffs in the feature/stress_formulation branch?

timofeymukha commented 2 months ago

I think it is used in the lift/drag, albeit as an input argument.

I think it boils down to the pointwise viscous drag computation, which needs the extra factor of 2 now. I just added that.

timofeymukha commented 2 months ago

The math is correct :D, and we need to change some stuffs in the feature/stress_formulation branch?

Yeah, we merge this eventually to the stress branch, and make adjustments there.