search

ExtremeFLOW / neko

/ᐠ. ｡.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
158 stars 27 forks source link

Fix BC at mixed neumann/dirichlet between elements #1255

Open MartinKarp opened 2 months ago

MartinKarp commented 2 months ago

Currently, if there is a Neumann and Dirichlet condition between two elements, the point at the element interface does not have a unique value. This PR addresses this, @vbaconnet is this an ok solution or did we come up with something else?

For meshes where the BC changes within one element (such as for boxes or the like), this is not an issue.

Before merging I guess this should be tested, but I don't have a mesh with bcs like this, does anyone have such a mesh? Preferably really small.

I need to check this is correctly done on the delta fields as well, which I guess it is not. The same thing applies to scalar and such as well, but I mostly wanted to get this discussion going.

vbaconnet commented 2 months ago

Yes this is what we had talked about! I can see if I have a small mesh to test this on.