search

ExtremeFLOW / neko

/ᐠ. ｡.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
158 stars 27 forks source link

Remove legacy scalar user bc #1262

Closed timofeymukha closed 2 months ago

timofeymukha commented 2 months ago

Basically the title. There seems to be no sense to keep the old pointwise bc as it can be easily replaced by the new one, which also supports GPUs.

timofeymukha commented 2 months ago

Fully agree with what has been stated, but removing the point wise apply also removes the possibility of running interactive with pyneko, and have the bc provided by e.g. a notebook

Hmm, would it be too far-fetched to say that we could in the future handle most scalar functions with expression parsing from the case file?

njansson commented 2 months ago

Fully agree with what has been stated, but removing the point wise apply also removes the possibility of running interactive with pyneko, and have the bc provided by e.g. a notebook

Hmm, would it be too far-fetched to say that we could in the future handle most scalar functions with expression parsing from the case file?

Difficult to say without having some kind of prototype in the pipeline

timofeymukha commented 2 months ago

Fully agree with what has been stated, but removing the point wise apply also removes the possibility of running interactive with pyneko, and have the bc provided by e.g. a notebook

Hmm, would it be too far-fetched to say that we could in the future handle most scalar functions with expression parsing from the case file?

Difficult to say without having some kind of prototype in the pipeline

Yeah, that's true. Also, a bit difficult to predict with pyneko as there are 0 users, and it is still not really released, right? I'm a bit torn here.

pschlatt1 commented 2 months ago

if it does not hurt, I would leave simple (as in known from Nek5000) ways of interacting with the field in the code. It is a research code, so people may want to do quick and dirty things at times.

timofeymukha commented 2 months ago

It does hurt somewhat because user routines are always special exceptions / corner cases one has to treat. But ok, if this is really needed then we can leave it.