search

ExtremeFLOW / neko

/ᐠ. ｡.ᐟ\ᵐᵉᵒʷˎˊ˗
https://neko.cfd/
Other
158 stars 27 forks source link

Remove check for more arguments #1271

Open MartinKarp opened 1 month ago

MartinKarp commented 1 month ago

Might be controversial, but enabling the input for more arguments than the case file might be good, especially if one wants to vary a lot of different parameters (especially between ranks) and make ensemble runs without changing the case file.

I don't think it hurts to relax this check.

adperezm commented 1 month ago

You really like command line arguments :P.

I think it is fair, and I guess that taking care of those arguments is responsibility of the user, but I still think it would be good to report them back just to be on the safe side.

If you do not agree, then ignoring this comment is fine. I do not really mind either way :D

MartinKarp commented 1 month ago

An alternative is of course, environment variables, which I guess could also be somehow preferred. I mostly wanted to raise this question as I will need to make quite a lot of ensemble runs.

njansson commented 1 month ago

How about instead adding proper command line arguments, as suggested by @adperezm? Something along the line of -v for detailed version information (compiler flags etc), -c jsonfile.case to run a case. There are of course several options, but would need some discussion on good naming for the switches.