search

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.
https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/
GNU General Public License v3.0
21 stars 1 forks source link

Fix Future Estimates #208

Closed ExtremeFiretop closed 6 months ago

ExtremeFiretop commented 6 months ago

Fix Future Estimates

ExtremeFiretop commented 6 months ago

@Martinski4GitHub

I basically re-did it all. :D This time, better? let me know :)

ExtremeFiretop commented 6 months ago

This seems to work with cron schedules like this:

/15 Or like this: 0-59/15 Or like this: 15 * Which none of these worked previously with the current method in the dev branch.

ExtremeFiretop commented 6 months ago

@Martinski4GitHub

I woke up this morning and still noticed a bug with "bad number" with specific crons and I realized it was because some days would come back as "00" and my code was scrapping the first zero away, but in those cases it was scrapping all the zeros away making it a null value.

This has been resolved in commit: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/208/commits/5d6a11929f70ca774a56880c7376bd779095841e I made the removal of the first 0 more specific and also assigned defaults incase somehow it still gets nulled somehow.

Problem is now gone, and I can set whatever postpone and cron schedule I want without error.

ExtremeFiretop commented 6 months ago

@Martinski4GitHub

Commit: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/208/commits/04a34ac5061e4367d0befa601e14ce9a5f61cc2a

Is as per Viktors suggestion in the SNB forums.

Martinski4GitHub commented 6 months ago

@ExtremeFiretop,

Apologies for the "radio silence." As you know, I was busy with family events during the weekend, and today I was busy with work commitments as well. I'll take a closer look at your latest code changes sometime this week, but I'm not sure when exactly (most likely until Wednesday evening at the earliest). After a quick look, I'd say that you're certainly honing your shell scripting skills, and that, in and of itself, is great to see. Good job bud.

ExtremeFiretop commented 6 months ago

@ExtremeFiretop,

Apologies for the "radio silence." As you know, I was busy with family events during the weekend, and today I was busy with work commitments as well. I'll take a closer look at your latest code changes sometime this week, but I'm not sure when exactly (most likely until Wednesday evening at the earliest). After a quick look, I'd say that you're certainly honing your shell scripting skills, and that, in and of itself, is great to see. Good job bud.

I've been looking at your code since October of last year 8 months ago, surely at some point some of it has to sink in, right? lol!

Martinski4GitHub commented 6 months ago

@ExtremeFiretop,

This evening, I've been running tests & validation using the latest code changes. So far everything is looking good. I'm going to have dinner right now and will come back to complete the testing & my review. It's likely this PR will be merged before I go to bed tonight. Good job bud.

ExtremeFiretop commented 6 months ago

@ExtremeFiretop,

This evening, I've been running tests & validation using the latest code changes. So far everything is looking good. I'm going to have dinner right now and will come back to complete the testing & my review. It's likely this PR will be merged before I go to bed tonight. Good job bud.

I'm about to go to bed myself cause as I mentioned I need to start getting myself back on a regular schedule, but if there's anything outstanding or you notice feel free to comment in a review or submit a PR and I'll see it first thing in the morning.

I did test this a bunch and it seemed to work as a cron, interactively, with no delay, with a long delay, with all types of crons. I was happy with this solution.

Thanks Martinski, Hope you've been doing good and work is treating you well, you know where to find me if you ever want to chat or discuss 😁

Martinski4GitHub commented 6 months ago

I'm about to go to bed myself cause as I mentioned I need to start getting myself back on a regular schedule, but if there's anything outstanding or you notice feel free to comment in a review or submit a PR and I'll see it first thing in the morning.

I did test this a bunch and it seemed to work as a cron, interactively, with no delay, with a long delay, with all types of crons. I was happy with this solution.

Thanks Martinski, Hope you've been doing good and work is treating you well, you know where to find me if you ever want to chat or discuss 😁

Thanks. Life & work has been good so far. This past week I was very busy with part of the planning phase of the next project so after the long hours, I took time in the evenings to relax, decompress, and spend time with the family.

Anyway, I finished testing and found no problems with my test cases. I did find some code to "clean up" and also ran the latest code through the Linter tool which pointed to some minor cleanup to do as well.

I'm going to merge this PR into the 'develop' branch and address the cleanup in a separate PR.

ExtremeFiretop commented 6 months ago

I'm going to merge this PR into the 'develop' branch and address the cleanup in a separate PR.

Thanks for the review my friend, and for testing and validating the behavior. :) I'm awake again, it's early but it was a solid 5-6 hours, it's going in the right direction.

Feel free to submit a PR with your cleanup and take your time, and I'll review when I get it :) I know how you feel about work, it's been randomly busy at my work as well.

I'm assuming this release can go out the door after your PR, it seems Gnuton is almost ready for his full release, but our Gnuton branch is synced up so I'll have a users do a final test with the Gnuton branch once the official firmware is released.