"Update" Menu Behavior - Githubissues

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.

https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/

GNU General Public License v3.0

21 stars 1 forks source link

"Update" Menu Behavior #262

Closed ExtremeFiretop closed 4 months ago

ExtremeFiretop commented 4 months ago

Working the update command. This is the current behavior after your PR: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/261

However, this is not what I intended. I only want the forceupdate to be used in specific situations.

When a user calls a forceupdate command externally such as: /jffs/scripts/MerlinAU.sh forceupdate like this below:
When changing the branches from dev to stable or vise versa such as: /jffs/scripts/MerlinAU.sh develop: like this below:

However when in the menu, if there is no update available, instead of using the force update, we should just use the regular update, like this:

This allows the user to review what they are about to do interactively, without "jumping the gun" so to speak :)

ExtremeFiretop commented 4 months ago

Oh right, Happy Independence Day @Martinski4GitHub !

Martinski4GitHub commented 4 months ago

Working the update command. This is the current behavior after your PR: #261 ...

However, this is not what I intended. I only want the forceupdate to be used in specific situations.

When a user calls a forceupdate command externally such as: /jffs/scripts/MerlinAU.sh forceupdate like this below: ...

When changing the branches from dev to stable or vise versa such as: /jffs/scripts/MerlinAU.sh develop: like this below: ...

However when in the menu, if there is no update available, instead of using the force update, we should just use the regular update, like this: ...

This allows the user to review what they are about to do interactively, without "jumping the gun" so to speak :)

Ah, OK. I see what you mean. What threw me off was the title of the menu option:

  up) Force Update MerlinAU Now

Where the word "Now" adds a sense of immediacy. IOW, "do this now and don't wait for me" kind of operation, which I understood as: "OK, we need to add the 'force' parameter."

However, I understand & agree with your originally intended functionality to use the "regular update call" for interactive sessions. My only suggestion would be to remove the word "Now" from the menu option titles so there is no sense of urgency.

  up) Update MerlinAU Script

  up) Force Update MerlinAU Script

What do you think?

Martinski4GitHub commented 4 months ago

Oh right, Happy Independence Day @Martinski4GitHub !

Thanks a lot, bud. We had a great family time today.

ExtremeFiretop commented 4 months ago

Working the update command. This is the current behavior after your PR: #261 ... However, this is not what I intended. I only want the forceupdate to be used in specific situations.

When a user calls a forceupdate command externally such as: /jffs/scripts/MerlinAU.sh forceupdate like this below: ...

When changing the branches from dev to stable or vise versa such as: /jffs/scripts/MerlinAU.sh develop: like this below: ...

However when in the menu, if there is no update available, instead of using the force update, we should just use the regular update, like this: ... This allows the user to review what they are about to do interactively, without "jumping the gun" so to speak :)

Ah, OK. I see what you mean. What threw me off was the title of the menu option:
  up) Force Update MerlinAU Now
Where the word "Now" adds a sense of immediacy. IOW, "do this now and don't wait for me" kind of operation, which I understood as: "OK, we need to add the 'force' parameter."

However, I understand & agree with your originally intended functionality to use the "regular update call" for interactive sessions. My only suggestion would be to remove the word "Now" from the menu option titles so there is no sense of urgency.
  up) Update MerlinAU Script
  up) Force Update MerlinAU Script
What do you think?

I think if it helps clarify the intention, lets do it! :) I'll make the change!

ExtremeFiretop commented 4 months ago

Oh right, Happy Independence Day @Martinski4GitHub !

Thanks a lot, bud. We had a great family time today.

Glad to hear! Do you get Monday off as well to make it an EXTRA long weekend? That would be nice! ;)

ExtremeFiretop commented 4 months ago

Change made here: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/262/commits/1bd03cb67deccfb7b1ac36b51802c03a9e664666

Martinski4GitHub commented 4 months ago

Oh right, Happy Independence Day @Martinski4GitHub !

Thanks a lot, bud. We had a great family time today.

Glad to hear! Do you get Monday off as well to make it an EXTRA long weekend? That would be nice! ;)

No, back to work on Monday, after the "5-day-long weekend" :>) We have a summer vacation planned by the end of August so I'm saving some of my vacation days for that.

ExtremeFiretop commented 4 months ago

Oh right, Happy Independence Day @Martinski4GitHub !

Thanks a lot, bud. We had a great family time today.

Glad to hear! Do you get Monday off as well to make it an EXTRA long weekend? That would be nice! ;)

No, back to work on Monday, after the "5-day-long weekend" :>) We have a summer vacation planned by the end of August so I'm saving some of my vacation days for that.

Fair enough! Still a very long weekend, considering Thursday and Friday off! Did you take Wednesday off too???!?!? Man I wish! They work my little public service fingers to the bones here in Canada ;)

Not sure if you saw this report in the Plugins compatibility thread: https://www.snbforums.com/threads/compatibility-findings-with-addons-with-gt-be98-pro.90657/post-916249

Doesn't sound related to your changes, but just figured I'd bring it up incase you had any gut feelings.

Martinski4GitHub commented 4 months ago

Oh right, Happy Independence Day @Martinski4GitHub !

Thanks a lot, bud. We had a great family time today.

Glad to hear! Do you get Monday off as well to make it an EXTRA long weekend? That would be nice! ;)

No, back to work on Monday, after the "5-day-long weekend" :>) We have a summer vacation planned by the end of August so I'm saving some of my vacation days for that.

Fair enough! Still a very long weekend, considering Thursday and Friday off! Did you take Wednesday off too???!?!? Man I wish! They work my little public service fingers to the bones here in Canada ;)

Yes, my days off started on July 3rd. At work, we got July 4th and 5th as company holidays.

Not sure if you saw this report in the Plugins compatibility thread: https://www.snbforums.com/threads/compatibility-findings-with-addons-with-gt-be98-pro.90657/post-916249

Doesn't sound related to your changes, but just figured I'd bring it up incase you had any gut feelings.

Yeah, I saw that earlier this evening when I was briefly browsing through the forums. He says the problem also exists in the current master 4.4.5 version so it's definitely unrelated to my changes in the "develop" version. But, I do have an idea of what the root cause is. I'll take a closer look. Thanks for the heads-up.

Martinski4GitHub commented 4 months ago

@ExtremeFiretop,

BTW, have you ever tried using the uiDivStats WebGUI for Diversion on your GT-BE98 PRO router?

I'll send you a PM on SNB about this. I don't want to go completely off-topic here.

ExtremeFiretop commented 4 months ago

@ExtremeFiretop,

BTW, have you ever tried using the uiDivStats WebGUI for Diversion on your GT-BE98 PRO router?

I'll send you a PM on SNB about this. I don't want to go completely off-topic here.

No, I haven't. I'm willing to test though!

Martinski4GitHub commented 4 months ago

@ExtremeFiretop, BTW, have you ever tried using the uiDivStats WebGUI for Diversion on your GT-BE98 PRO router? I'll send you a PM on SNB about this. I don't want to go completely off-topic here.

No, I haven't. I'm willing to test though!

OK, I appreciate that. We'll talk more tomorrow via PMs on SNB. Now, go to have a good, long sleep, bud!!

ExtremeFiretop commented 4 months ago

Synced with Gnuton here: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/186/commits/a3dd4551e6c9f3f9731d91396b0000f6e539bfc7