search

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.
https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/
GNU General Public License v3.0
21 stars 1 forks source link

Fixes and code improvements #276

Closed Martinski4GitHub closed 3 months ago

Martinski4GitHub commented 3 months ago
Martinski4GitHub commented 3 months ago

@ExtremeFiretop,

Please review & run testing & verification for this PR whenever you have the time. I've tested & validated as much as I could, but a 2nd pair of eyes never hurts, of course. :>)

ExtremeFiretop commented 3 months ago
  • Fixed a couple of "variable not set" errors.

Can you point this out for me? Lots of small changes that drown out the important one lol!

Martinski4GitHub commented 3 months ago
  • Fixed a couple of "variable not set" errors.

Can you point this out for me? Lots of small changes that drown out the important one lol!

I was about to go to bed when I saw your message, LOL!! I'll add comments to the respective lines on your PR #275 (easier to point them out).

ExtremeFiretop commented 3 months ago

All great catches @Martinski4GitHub ! Especially the unset variable! All the other improvements are much appreciated as well! :)

ExtremeFiretop commented 3 months ago

(easier to point them out).

So you feel my struggle? 🤣 All tested well so far!

ExtremeFiretop commented 3 months ago

Synced with Gnuton is commit: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/186/commits/1b018f140f828f42064610e07213a41e4a872833