search

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.
https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/
GNU General Public License v3.0
21 stars 1 forks source link

Clarify Email Content #280

Closed ExtremeFiretop closed 3 months ago

ExtremeFiretop commented 3 months ago

Clarify Email Content as requested by:

https://www.snbforums.com/threads/merlinau-v1-2-6-the-ultimate-firmware-auto-updater-now-available-in-amtm.88577/post-920655

Also, noticed that when the primary emails about updates for the nodes it looked a bit weird:

image

Basically I'd get an update email notification, the subject made it sound like the primary had an update (GT-BE98Pro), but then reading you could tell it was a node update. (GT-AXE11000)

So I addressed both my nitpick and the user request at the same time.

Martinski4GitHub commented 3 months ago

Also, noticed that when the primary emails about updates for the nodes it looked a bit weird: ... Basically I'd get an update email notification, the subject made it sound like the primary had an update (GT-BE98Pro), but then reading you could tell it was a node update. (GT-AXE11000)

Nice catch!!

Martinski4GitHub commented 3 months ago

@ExtremeFiretop, Did you just delete my previous comment by accident??

ExtremeFiretop commented 3 months ago

@ExtremeFiretop, Did you just delete my previous comment by accident??

Yes I was trying to delete my comment from the other PR.

Martinski4GitHub commented 3 months ago

@ExtremeFiretop, Did you just delete my previous comment by accident??

Yes I was trying to delete my comment from the other PR.

That's what happens when you haven't had your full cup of coffee to really wake up!! LOL!!

ExtremeFiretop commented 3 months ago

@ExtremeFiretop, Did you just delete my previous comment by accident??

Yes I was trying to delete my comment from the other PR.

That's what happens when you haven't had your full cup of coffee to really wake up!! LOL!!

My eyes are blurry and I'm on my phone, I lost track of what PR I was on and just scrolled to the bottom on my phone and hit the delete button. Lol.

I realized my reply on the other PR was a bit dry, so I just wanted to delete it and re-write the fact that I had seen that in testing and was already fixed locally.

The only thing you did differently was you choose a different location to do the update for the function. Otherwise they were pretty much identical.

ExtremeFiretop commented 3 months ago

Synced with Gnuton in commit: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/186/commits/c63a57722605103b1f40f893fdbde20f0a92a970