Increased Maximum Postponement Days

[Martinski4GitHub]

Increased the maximum number of postponement days to 199. This gives users plenty of time to wait and decide when to do the F/W Update, especially for those users who prefer to do it manually.

[ExtremeFiretop]

Easy peasy change, just reading it is good enough for stuff like this ;) Good idea, not sure why we picked 2 months, I guess we just picked an arbitrary number to start. User can delay and delay and delay, why not.

[ExtremeFiretop]

Synced with Gnuton in commit: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/186/commits/0d966aedd3fa1f1af31c74acecf0dc6b957578cf

[Martinski4GitHub]

Easy peasy change, just reading it is good enough for stuff like this ;) Good idea, not sure why we picked 2 months, I guess we just picked an arbitrary number to start. User can delay and delay and delay, why not.

Yeah, this was brought up by the user in the SNB Forum who still wants to do manual F/W updates at their own time, but can still benefit from all the advantages that MerlinAU can offer, including F/W Update notifications. I figure that for all intents and purposes, a little a bit over a 6-month delay should be plenty to wait & decide for any user.

[Jeffofmany]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

[ExtremeFiretop]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits.

Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

But I can for sure look into sending the email again, that is not a bad idea.

[ExtremeFiretop]

Hey @Martinski4GitHub

I remember why we set it to 2 months. Because the script needs to do postponement day calculations when an update is detected and this can take some time if it's a long postpone period.

Just a thought. I realize 99% of the time anyways that calculation will happen after hours while people are sleeping, but in the off chance a new update is available and someone instantly opens MerlinAU, it will do the calculations for the estimated runday at that time.

[Martinski4GitHub]

I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" ...

This part of the request description is highly unclear, vague, and open to misinterpretation.

OOH, you appear to request "setting of 0 to mean disable" but currently a setting of 0 already means no postponement days (i.e. no delay = postponement disabled).

OTOH, you also appear to request "setting of 0 to mean delay forever" but a setting of 0 cannot mean both "no delay" and "delay forever" simultaneously. That would not make any sense at all.

[Martinski4GitHub]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits.

Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

??? I'm confused. A change in text??? ZERO postponement days already means no delay.

[ExtremeFiretop]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits. Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

??? I'm confused. A change in text??? ZERO postponement days already means no delay.

He's asking for it to say Disabled. Instead of 0, on the main menu I believe. (I,e a change in text/wording as I put it)

[Martinski4GitHub]

Hey @Martinski4GitHub

I remember why we set it to 2 months. Because the script needs to do postponement day calculations when an update is detected and this can take some time if it's a long postpone period.

Just a thought. I realize 99% of the time anyways that calculation will happen after hours while people are sleeping, but in the off chance a new update is available and someone instantly opens MerlinAU, it will do the calculations for the estimated runday at that time.

Yeah, I tested with 199 days (the new maximum) several times during an interactive session and the calculation delay was barely noticeable. AFAICT, we're still OK with a ~6-month postponement period as a maximum. Most people will likely never go that far.

[ExtremeFiretop]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits. Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

??? I'm confused. A change in text??? ZERO postponement days already means no delay.

He's asking for it to say Disabled. Instead of 0, on the main menu, I believe.

At least, that's my interpretation of the request.

[ExtremeFiretop]

Hey @Martinski4GitHub I remember why we set it to 2 months. Because the script needs to do postponement day calculations when an update is detected and this can take some time if it's a long postpone period. Just a thought. I realize 99% of the time anyways that calculation will happen after hours while people are sleeping, but in the off chance a new update is available and someone instantly opens MerlinAU, it will do the calculations for the estimated runday at that time.

Yeah, I tested with 199 days (the new maximum) several times during an interactive session and the calculation delay was barely noticeable. AFAICT, we're still OK with a ~6-month postponement period as a maximum. Most people will likely never go that far.

Fantastic ! Then all good here!

[Martinski4GitHub]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits. Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

??? I'm confused. A change in text??? ZERO postponement days already means no delay.

He's asking for it to say Disabled. Instead of 0, on the main menu, I believe.

As mentioned, I don't really understand what the poster is asking. If he's actually asking to change 0 to DISABLED, I don't see the point. The menu option is clearly & explicitly asking for "number of days to postpone the update once a new firmware notification is made." Entering 0 means no delay. I don't really see what the confusion is.

[Martinski4GitHub]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits. Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

??? I'm confused. A change in text??? ZERO postponement days already means no delay.

He's asking for it to say Disabled. Instead of 0, on the main menu, I believe.

At least, that's my interpretation of the request.

I'd say let's wait for the poster to rephrase his request in a more clear and precise sentence. Otherwise, it's all assumptions about what he meant to say.

[ExtremeFiretop]

I tried to post to the SNB Forum thread and received the message "You cannot reply to threads older than 6 months. Please start a new thread on this topic." I wanted to suggest maybe a setting of "0" to delay F/W updates to provide a "disable" -and- Also, it seems the notification is emailed one time. Perhaps the ability to send the email daily/weekly until F/W update is completed? You know, for us masochists...lol

First of all, thank you for letting me know the thread has reached its limits. Second of all, in the case of disable vs 0, it's really the same thing it would just be a change in text, considering the option is to select a number of days, 0 seemed to make sense.

??? I'm confused. A change in text??? ZERO postponement days already means no delay.

He's asking for it to say Disabled. Instead of 0, on the main menu, I believe.

As mentioned, I don't really understand what the poster is asking. If he's actually asking to change 0 to DISABLED, I don't see the point. The menu option is clearly & explicitly asking for "number of days to postpone the update once a new firmware notification is made." Entering 0 means no delay. I don't really see what the confusion is.

My response was based on the only logical thing the request could mean.

The underlying assumption in my response being a wording change, is that most of our menu options don't have numbers or days (with the exception of the cron under advanced) So my assumption (again based on my interpretation) is that he just wants it to say "Currently Disabled" if you set the number of days to 0.

Maybe he thinks, "Currently: Disabled" makes more sense than "Current Days: 0"

Vs

Maybe it's not that it makes more sense to him, maybe he just likes the look more. I'm not sure LOL. I'm just filling you in on my response based on how i took the initial request/understanding

[ExtremeFiretop]

(And either way, my response was no.)

So even if he does respond that this is what he means. The answer is no.

[Jeffofmany]

I'm sorry for the late response and confusion. I have looked at the MerlinAU closer, I see now. The only thing that is even worth rephrasing might be it would be a neat option to be able to get the email notification more than once. Any implementation of that would be great. I'm so busy with other stuff, please understand.

[ExtremeFiretop]

I'm sorry for the late response and confusion. I have looked at the MerlinAU closer, I see now. The only thing that is even worth rephrasing might be it would be a neat option to be able to get the email notification more than once. Any implementation of that would be great. I'm so busy with other stuff, please understand.

No worries. Martinski likes things clear 😉 I'm just making lots of assumptions since as we both mentioned, disabled and 0 are the same.

Again, thank you for reporting the thread reaching its limits, and the idea on email reminder schedules. And finally... thank you for using MerlinAU! 😉