Minor Bug Fix (Pre-Sync)

ExtremeFiretop / MerlinAutoUpdate-Router

Merlin(A)uto(U)pdate is a Merlin router script which allows you to remotely identify a stable firmware update for an ASUS Merlin router, and automatically download and update via an unattended method directly from the router.

https://www.snbforums.com/threads/merlinau-v1-2-7-the-ultimate-firmware-auto-updater-amtm-addon.91326/

GNU General Public License v3.0

21 stars 1 forks source link

Minor Bug Fix (Pre-Sync) #283

Closed ExtremeFiretop closed 3 months ago

ExtremeFiretop commented 3 months ago

Minor Bug Fix for the newest feature, and some Pre-Sync for Gnuton in the SelectOfflineUpdateFile function as well as the wording.

The bug I am fixing can be found below:

This is only when using the latest feature from PR 275 for advanced updates, and as you can see, it thinks it failed when it didn't. The currently installed version is correct, but not the version being installed.

Also synced up some wording changes to be more generic and less "zip" talk for the upcoming merge with Gnuton.

ExtremeFiretop commented 3 months ago

@Martinski4GitHub

Undid some of the wording changes, I'll make the wording more Gnuton specific in the Gnuton branch instead, as to not confuse users today.

ExtremeFiretop commented 3 months ago

I'll have to adjust the logic, in testing I realize that the email won't have access to that variable sadly.

I'll have to export it? Or just not send the email. What do you think? @Martinski4GitHub

ExtremeFiretop commented 3 months ago

I'm leaning towards not sending the email. (No post reboot hook) If the offline updated was triggered.

User should be aware they are doing the update, right? Lol

Martinski4GitHub commented 3 months ago

I'll have to adjust the logic, in testing I realize that the email won't have access to that variable sadly.

I'll have to export it? Or just not send the email. What do you think? @Martinski4GitHub

Which variable exactly?? Too many vars to keep track of...

ExtremeFiretop commented 3 months ago

I'll have to adjust the logic, in testing I realize that the email won't have access to that variable sadly. I'll have to export it? Or just not send the email. What do you think? @Martinski4GitHub

Which variable exactly?? Too many vars to keep track of...

I FEEEEELS YOU! Hahahaha The release_version variable will only be populated at the start of the run, when the post reboot hook is trigger that variable is blank. So the email won't have access to it.

Martinski4GitHub commented 3 months ago

I'm leaning towards not sending the email. (No post reboot hook) If the offline updated was triggered.

That's certainly a valid option. Since the new feature runs only in interactive mode, the "advanced user" is expected to know that a F/W update just occurred.

Martinski4GitHub commented 3 months ago

I'll have to adjust the logic, in testing I realize that the email won't have access to that variable sadly. I'll have to export it? Or just not send the email. What do you think? @Martinski4GitHub

Which variable exactly?? Too many vars to keep track of...

I FEEEEELS YOU! Hahahaha The release_version variable will only be populated at the start of the run, when the post reboot hook is trigger that variable is blank. So the email won't have access to it.

Ah, yes, the var holding the new F/W version that was just installed. Since the F/W update comes from an "offline" source, the F/W version is extracted from the file name itself or from whatever the user types in as the version string. Either way, the advanced user should know what's going on so I agree that the email is unnecessary.

Martinski4GitHub commented 3 months ago

@ExtremeFiretop,

I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

ExtremeFiretop commented 3 months ago

@ExtremeFiretop,

I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

I gotta say I don't know exactly where you work or what you do, but ASUS could use a dev like you! 😉 Goodnight buddy

ExtremeFiretop commented 3 months ago

Undid the changes to allow raw files. Updated the fix for the post email when using offline feature.

Martinski4GitHub commented 3 months ago

@ExtremeFiretop, I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

I gotta say I don't know exactly where you work or what you do, but ASUS could use a dev like you! 😉 Goodnight buddy

Thanks for the kind words & the vote of confidence.

P.S. I was just informed by "the powers that be" that tonight is "movie night" in our house so I'm going to start earlier this evening to review and comment before dinner & the movie :>) LOL!!!

ExtremeFiretop commented 3 months ago

@ExtremeFiretop, I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

I gotta say I don't know exactly where you work or what you do, but ASUS could use a dev like you! 😉 Goodnight buddy

Thanks for the kind words & the vote of confidence.

P.S. I was just informed by "the powers that be" that tonight is "movie night" in our house so I'm going to start earlier this evening to review and comment before dinner & the movie :>) LOL!!!

This PR I think is mostly ready, if Gnuton waits. It waits ;)

Martinski4GitHub commented 3 months ago

@ExtremeFiretop, I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

I gotta say I don't know exactly where you work or what you do, but ASUS could use a dev like you! 😉 Goodnight buddy

Thanks for the kind words & the vote of confidence. P.S. I was just informed by "the powers that be" that tonight is "movie night" in our house so I'm going to start earlier this evening to review and comment before dinner & the movie :>) LOL!!!

This PR I think is mostly ready, if Gnuton waits. It waits ;)

OK, let me know when it's fully ready & finalized for review. No rush. I can review it after the movie. Not a lot of code changes (so far) so it should be a fairly quick review.

ExtremeFiretop commented 3 months ago

@ExtremeFiretop, I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

I gotta say I don't know exactly where you work or what you do, but ASUS could use a dev like you! 😉 Goodnight buddy

Thanks for the kind words & the vote of confidence. P.S. I was just informed by "the powers that be" that tonight is "movie night" in our house so I'm going to start earlier this evening to review and comment before dinner & the movie :>) LOL!!!

This PR I think is mostly ready, if Gnuton waits. It waits ;)

OK, let me know when it's fully ready & finalized for review. No rush. I can review it after the movie. Not a lot of code changes (so far) so it should be a fairly quick review.

Oh I meant it's ready. I say mostly. In case you find something.

Martinski4GitHub commented 3 months ago

@ExtremeFiretop, I got to hit the sack!! I'm going to the office tomorrow so I've to get up early for the drive. Talk to you tomorrow evening to continue the discussion. Have a good night, bud.

I gotta say I don't know exactly where you work or what you do, but ASUS could use a dev like you! 😉 Goodnight buddy

Thanks for the kind words & the vote of confidence. P.S. I was just informed by "the powers that be" that tonight is "movie night" in our house so I'm going to start earlier this evening to review and comment before dinner & the movie :>) LOL!!!

This PR I think is mostly ready, if Gnuton waits. It waits ;)

OK, let me know when it's fully ready & finalized for review. No rush. I can review it after the movie. Not a lot of code changes (so far) so it should be a fairly quick review.

Oh I meant it's ready. I say mostly. In case you find something.

OK, got it; reviewing now...

ExtremeFiretop commented 3 months ago

Enjoy your movie!!!