search

Exygy / dahlia-listings

Bay Area Regional DAHLIA Listings site.
GNU General Public License v3.0
1 stars 0 forks source link

Add relevant content to meta tags #70 #71

Closed jaredcwhite closed 4 years ago

jaredcwhite commented 4 years ago

Fixes #70

jacchau commented 4 years ago

Thanks for setting up the testing environment.

I ran it through the following preview card validators: Facebook: https://developers.facebook.com/tools/debug/sharing Linkedin: https://www.linkedin.com/post-inspector/inspect/ Twitter: https://cards-dev.twitter.com/validator

The individual listing pages look good for both Facebook and Linkedin. Outstanding issues: 1) Image tag for Homepage and Listings pages: Will the image tag be updated to the hero image when we push this to prod? It's currently set as 'https://herokuapp.com/images/test-banner.jpg '. 2) For some reason the Twitter card isn't working https://cards-dev.twitter.com/validator and I see that you have tags specifically created for Twitter.

jaredcwhite commented 4 years ago

@jacchau Yeah, there's no hero image for the test group, but it should work once it's for either SJ for SMC proper. The Twitter card validation seems like it's not working since the robots.txt file is blocking it, but you can view source and look at the twitter: meta tags to make sure they match the Open Graph tags.

jacchau commented 4 years ago

Thanks @jaredcwhite for the clarification and looks good. Ready for @bk3c to merged this after his code review.

bk3c commented 4 years ago

I have a couple of minor comments (e.g. I'd like to see the default tags come back) but given that this is already merged I think we just need to fix them in Bloom.