Problem with build on node 8

anagami commented 6 years ago

Hi! i use fork from @mixer and try install lwip on Ubuntu node 8.7.0 build failing with error ../src/decoder/png_decoder.cpp:6:34: error: ‘png_const_bytep’ was not declared in this scope

jwater7 commented 6 years ago

I'm getting a build error with latest Ubuntu as well..but looks a little different but still I think it's a problem with the libpng dependency.

  CC(target) Release/obj.target/lwip_decoder/src/lib/png/png.o
In file included from ../src/lib/png/png.c:14:0:
../src/lib/png/pngpriv.h:805:4: error: #error ZLIB_VERNUM != PNG_ZLIB_VERNUM "-I
 (include path) error: see the notes in pngpriv.h"
 #  error ZLIB_VERNUM != PNG_ZLIB_VERNUM \
    ^~~~~
lwip_decoder.target.mk:165: recipe for target 'Release/obj.target/lwip_decoder/src/lib/png/png.o' failed
make: *** [Release/obj.target/lwip_decoder/src/lib/png/png.o] Error 1
make: Leaving directory '/home/johnny/proj/example/node_modules/lwip/build'
gyp ERR! build error

dmitryt commented 6 years ago

The same on MacOS node 8.2.1, even though it works well under node 7.5

D0bhareach commented 6 years ago

I was able to install with node 6.9.1

EyalAr / lwip

Problem with build on node 8 #311