Eydcao / BSMS-GNN

Apache License 2.0
47 stars 7 forks source link

Transition between levels #6

Closed sebestyenja closed 1 month ago

sebestyenja commented 1 month ago

Dear Yadi Cao,

I have a question about your model.

When the transition is happening between the different layers, does the node samples itself into the next layer or only the neighbouring nodes are aggregated? With other words, do self edges exist is the convolutional step between layers?

Thank you four your kind help!

sebestyenja commented 1 month ago

One more question. The BSMS-GNN use latent edge features only in the first, finest graph, then every other layer works as a graph convolution without any latent edge features, including the last, finest level in the up loop. Is that correct or I am mistaken? Thank you again!

Eydcao commented 1 month ago
  1. Self edge exists or not is a design choice; it's just like adding a res connection or not before the node MLP
  2. our edge feature will cat with the vector of itself, ie x_i - x_j, and its length. It includes the direction/offset between node pairs.