Feature/admin - Githubissues

EyeSeeTea / FIRE-WiFiCalling

WiFi Calling App to be used with LibreServer

GNU General Public License v3.0

5 stars 1 forks source link

Feature/admin #44

Closed MurhafSousli closed 7 years ago

MurhafSousli commented 7 years ago

This PR is still WIP

adrianq commented 7 years ago

[x] add id in accept/reject
[ ] post notification for single user (we will implement bulk notification in the future)
[x] translation not working for topped_up

adrianq commented 7 years ago

This PR is ready to be reviewed, right @MurhafSousli?

MurhafSousli commented 7 years ago

@adrianq Yes it is ready, however topped_up translation is not resolved yet

MurhafSousli commented 7 years ago

@adrianq Thanks for the fix, I was blind

adrianq commented 7 years ago

No worries :) Sometimes a look from an outsider is all that is needed.

MurhafSousli commented 7 years ago

Multilanguages is missing for users and billing, also notifications is not 100% complete since we will update it with the new response format, so there will be a new PR to complete the Admin.

Also some improvements was added in the next PRs, like displaying confirmation dialog. Changes could cause some conflicts with Feature/Menu PR because the PRs are chained.

Would like to proceed with this and add the multilanguages in the completion PR or just do it in this one?

adrianq commented 7 years ago

Makes all the sense. Merging this one... and, as you said, convert to multilanguage in the new PR.