search

EyeSeeTea / FIRE-WiFiCalling

WiFi Calling App to be used with LibreServer
GNU General Public License v3.0
5 stars 1 forks source link

About settings page #48

Closed MurhafSousli closed 7 years ago

MurhafSousli commented 7 years ago

@adrianq I am looking at the settings page

I understand that we are going to make the base URL for all requests dynamic, right?

The settings page has 3 fields, 2 of them are user and current password which we get from the user endpoint. But where do we get the server IP? the current user interface does not have a server property.

I also noticed that the menu for unauthenticated users shows the settings page. in this case user and current password would not make sense!

What do you think? thanks

adrianq commented 7 years ago

I would say that for the moment when you start the app the first time the server url is the current one (dev.est:5000). It will be for now hardcoded in the source code. The user can change it using the settings panel. If so we will use the one provided by the user. In the future (second iteration) we can revisit this and maybe start the app without any server url configured. This would be a minimum change though.

Re the menu, you are right. Not sure why it is like that. For the moment, keep it like that. Username and password field will be empty for unauthenticated users. We can discuss this on our next FIRE meeting and maybe disable the fields but I don't want to give you a suggestion without discussing it with the guys...