Feature/skeleton - Githubissues

EyeSeeTea / FIRE-WiFiCalling

WiFi Calling App to be used with LibreServer

GNU General Public License v3.0

5 stars 1 forks source link

Feature/skeleton #8

Closed tokland closed 7 years ago

tokland commented 7 years ago

Fixes #3

tokland commented 7 years ago

Using existing ion-icons. I have the app icon, whenever we have the rest we can add it (apparently building a font with the images and using font-awesome).

adrianq commented 7 years ago

Re the new icons, I also created a new issue for that. Let's try to merge this PR asap so we have a base in development to work with. Thank you guys!

tokland commented 7 years ago

Proposals applied. Some notes:

For now, I've not removed the suffix Page from pages, I checked the refence app (https://github.com/ionic-team/ionic-conference-app/tree/master/src/pages), and they do have them.
Documentation is scarce, but it seems that putting .module.ts is the way to use the modules lazily. Users comment that, as a rule of thumb, it's easier not to have [page].module.ts, remove @IonicPage decoration, and put it in app.module.ts. That's why I've done. Ionic-conference-app does not have this module files either.

adrianq commented 7 years ago

Thanks @tokland! I have approved the PR. @jordibc now it is your turn!

jordibc commented 7 years ago

@adrianq hopefully that was not to be done on Friday... I haven't forgotten, it's coming soon :) Nudge me if there's a deadline or something that I'm missing.

adrianq commented 7 years ago

@jordibc Pinging you! :) Can you review the PR asap? There is a new guy that is about to start helping us with this Project and don't want to mess him around with more branches. If you don't have time for this, just give me a shout and I will merge the PR. It should be fine, we are already using this code in some other branches.

jordibc commented 7 years ago

Thanks for the heads-up, I'm on it!

jordibc commented 7 years ago

Thanks for your patience. As far as my inexperience with ionic goes, this looks good to me. The only thing would be, do we want to have the .module.ts files in each page? Or just in app/app.module.ts?