EyeSeeTea / SurveillanceCambodiaApp

Mobile application designed to report cases of malaria (to a DHIS2 server) for Cambodia (pictureapp blessed repository)
GNU General Public License v3.0
0 stars 0 forks source link

Blanks and Incorrect Ordering - Review Screen #111

Closed QISPSK closed 7 years ago

QISPSK commented 7 years ago

image

Changing answers mid-survey lead to inconsistent ordering of the review screen and, occasionally, blanks

ifoche commented 7 years ago

This is happening because to build that review screen we're looping across all the values defined for the survey. When you change a value in the middle, that can force any question that depends on that answer to be deleted (and that's why the blanks). As new values are added at the end of the other ones when we follow all of them we find the new one as the last and represent it accordingly. The way I would solve it is by asking each value for its question, and then sort all values according to their questions order, and not representing empty values. This is relatively easy to do, but some performance problem could appear, and that's why the complexity med label instead of the low one.

QISPSK commented 7 years ago

@ifoche the solution makes sense, go ahead and test it out and we can see if we run into any issues on our end

ifoche commented 7 years ago

Fine, we'll go for it

QISPSK commented 7 years ago

screenshot_2017-05-02-09-38-43

@ifoche, Incorrect ordering still an issue when changing options after reaching the review screen.