search

EyeSeeTea / SurveillanceCambodiaApp

Mobile application designed to report cases of malaria (to a DHIS2 server) for Cambodia (pictureapp blessed repository)
GNU General Public License v3.0
0 stars 0 forks source link

Remove Ability to Change Font Size #90

Closed QISPSK closed 7 years ago

QISPSK commented 8 years ago

Can you please remove the ability to change the font size? The default font size works well (we haven't had any complaints so far) and the other font size options make the application difficult to use. A number of providers have accidentally turned on a different font size and have been unsure how to change it back.

ifoche commented 7 years ago

@QISPSK We've refactored the way we implemented the font sizes, can you please give it a try and let us know if it doesn't work as it is now?

QISPSK commented 7 years ago

image

Moved back to "Backlog" as custom font sizes are not translated to Khmer. Translations are as follows:

  1. Extra Small: តូចបំផុត
  2. Small: តូច
  3. Medium: មធ្យម
  4. Large: ធំ
  5. Extra Large: ធំបំផុត
QISPSK commented 7 years ago

Also, font size changes seem to only affect the question, not the answer, though I assume this has to do with the fact that the answer options are still images

ifoche commented 7 years ago

Yes, you're right, the questions cannot adapt to that font size because they are images. In that sense. If we go for using floating text on top of the options, that would be a bigger change.

For the translations, you're also right, it seems we're not using the POEditor strings. Sorry for that. That's a quick fix. I use this last change to define the issue complexity label

rodmelia commented 7 years ago

We agreed not to use dynamic text for the answers- we tried before and the solution was not satisfactory.

If we want to try again, we can do so in a future release, for which we need to design a more elaborate solution and a new estimation

On Thu, 20 Apr 2017 at 06:02, Ignacio Foche notifications@github.com wrote:

Yes, you're right, the questions cannot adapt to that font size because they are images. In that sense. If we go for using floating text on top of the options, that would be a bigger change.

For the translations, you're also right, it seems we're not using the POEditor strings. Sorry for that. That's a quick fix. I use this last change to define the issue complexity label

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/EyeSeeTea/SurveillanceCambodiaApp/issues/90#issuecomment-295662229, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRv6iY8yAEfJpFqGSDHOWUUNN5CwyLPks5rxy05gaJpZM4I9sWC .

QISPSK commented 7 years ago

@ifoche and @rodmelia thanks for the explanations! @ifoche if you can go ahead and simply link these up with the POEditor translations, that would be great.

ifoche commented 7 years ago

Sure