EyeSeeTea / SurveillanceCambodiaApp

Mobile application designed to report cases of malaria (to a DHIS2 server) for Cambodia (pictureapp blessed repository)
GNU General Public License v3.0
0 stars 0 forks source link

Monitor Module and Historical Values #99

Closed QISPSK closed 8 years ago

QISPSK commented 8 years ago

On both the newest version of the app (1.2.5) and the newest master BB build (43), historical values do not seem to be adding to totals in the monitor module. For example, QIS_test_int has seen 4 cases of Pf this month and 1 case of Pv, however the monitor module only shows 3 cases of Pf and 0 of Pv due to the fact that the two most recent cases were sent after historical values were updated. The same issue is present in the amount of DHA-PIP (and, I assume, AS/MQ) used.

This will likely be a persistent issue until all phones are upgraded to the newest BB version when it's release to the Play Store. In the meantime, can you change the monitor module calculations to include both the new and historical values?

ifoche commented 8 years ago

Hi @QISPSK. I don't know if I'm properly understanding the issue. Let me tell you my guess.

The app is not automatically refreshing the monitor module when a survey is sent and to do so, you have to manually move to another tab and then back again to monitor. Remember that monitor module is showing only the statistics for the sent surveys (not for those pending to be sent). Hence, once you finish a survey, that will not be automatically in the monitor module, you have to wait for them to disappear from the "pending" list to be sure that it will be in the monitor module. That is the current behaviour.

So the question here is, what behaviour would you expect? 1 - Do you expect the monitoring table to represent also the not yet accepted data? 2 - If that's not the case, do you expect the monitoring table to be automatically refreshed (and so, the dropdown state to be saved in order to set it up again once the module is refreshed)? 3 - Maybe the issue is not 1 or 2 and I didn't get the point. In that case, can you elaborate more on this?

josemp10 commented 8 years ago

@ifoche, this is something we are going to solve from the server side (I already talked to @QISPSK about that). It is because having the old option codes values with the new ones in the server

On 16 Sep 2016 10:54, "Ignacio Foche" notifications@github.com wrote:

Hi @QISPSK https://github.com/QISPSK. I don't know if I'm properly understanding the issue. Let me tell you my guess.

The app is not automatically refreshing the monitor module when a survey is sent and to do so, you have to manually move to another tab and then back again to monitor. Remember that monitor module is showing only the statistics for the sent surveys (not for those pending to be sent). Hence, once you finish a survey, that will not be automatically in the monitor module, you have to wait for them to disappear from the "pending" list to be sure that it will be in the monitor module. That is the current behaviour.

So the question here is, what behaviour would you expect? 1 - Do you expect the monitoring table to represent also the not yet accepted data? 2 - If that's not the case, do you expect the monitoring table to be automatically refreshed (and so, the dropdown state to be saved in order to set it up again once the module is refreshed)? 3 - Maybe the issue is not 1 or 2 and I didn't get the point. In that case, can you elaborate more on this?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/EyeSeeTea/SurveillanceCambodiaApp/issues/99#issuecomment-247550960, or mute the thread https://github.com/notifications/unsubscribe-auth/AD9HZ-2N-MMMIZurlrAvGwEBBQsT2cJjks5qqlkpgaJpZM4J-s95 .

ifoche commented 8 years ago

Hi @josemp10. Ok, that's fine. Thanks

josemp10 commented 8 years ago

BAO has submitted the script to the server (updates historical option codes values to the current ones). It runs every 24 hours at 10 am EST.