search

EyeSeeTea / WHO-custom-forms

Custom forms developed for WHO
GNU General Public License v3.0
0 stars 0 forks source link

Feature/mal wmr custom form #82

Closed deeonwuli closed 1 year ago

deeonwuli commented 1 year ago

:pushpin: References

Closes https://app.clickup.com/t/30rffq9

:memo: Implementation

:art: Screenshots

jordibc commented 1 year ago

Hi @deeonwuli ! I am looking at your changes trying to understand what fixes the problem of receiving too many notifications.

It seems that the previous-to-last commit (https://github.com/EyeSeeTea/WHO-custom-forms/pull/82/commits/302eeff4f09f45427fd63d3abc09dd317afea1a9) fixes it by sending the notifications when the value changes, instead of every time a key is up. This seems right to me.

Then, the last commit (https://github.com/EyeSeeTea/WHO-custom-forms/pull/82/commits/fbb8f09059eeb42c9932ea3fad06bc82659476aa) seems to have a few changes that look more like debugging the code, with some whitespace changes that don't look like fixing the format, a console.log(...) and some more changes that look like they may be wrong or at least I can't see how they are fixing things.

Is my understanding of the commits more or less right? And could it be that there was something wrong with the last commit?

Thanks!

deeonwuli commented 1 year ago

Hi @deeonwuli ! I am looking at your changes trying to understand what fixes the problem of receiving too many notifications.

It seems that the previous-to-last commit (302eeff) fixes it by sending the notifications when the value changes, instead of every time a key is up. This seems right to me.

Then, the last commit (fbb8f09) seems to have a few changes that look more like debugging the code, with some whitespace changes that don't look like fixing the format, a console.log(...) and some more changes that look like they may be wrong or at least I can't see how they are fixing things.

Is my understanding of the commits more or less right? And could it be that there was something wrong with the last commit?

Thanks!

hi @jordibc your understanding of the commits is very correct. although, the last commit was to fix an issue users were experiencing on production where they were spammed with messages each time data elements load. i figured the problem was two data elements that were triggered on load: cXhCtEy97u4 and ESgGpWE6H5z. i've reverted the last commit now and made changes to ensure that only those two are not triggered.