search

EyeSeeTea / dhis2-android-capture-app-psi-fork

PSI fork of official UiO Android app (blessed repository)
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Error with 'Assign' Program rules #11

Closed nancyespinoza closed 3 years ago

nancyespinoza commented 3 years ago

The 2.3.1 Fork is not applying any of the assign rules for HNQI/RDQA programs.

How to replicate

Test against 2.3.1 android capture app (https://github.com/dhis2/dhis2-android-capture-app/releases/tag/2.3.1) with the user android (password Fork.2020).

  1. Open any TEI in the HNQIS Program
  2. Open the Assessment stage
  3. Go to the Critical steps calculations or Scores and you'll see all the values are being assigned correctly
  4. Now with the same credentials and the 2.3.1 FORK repeat the steps and you'll see the values are not being assigned.

You can also test this with RDQA Program

ifoche commented 3 years ago

@nancyespinoza as far as we can see, the problem is also happening in the official UiO Android app (testing in https://dev.psi-mis.org with the user that you wrote above) and using the App in its 2.3.1 version (downloaded from GPlay).

Looking into it, looks like the events you download when you download a TEI that was not created in that device, are not coming with their datavalues. So if you create the event locally, the rules are working, or if you modify an existing event and start adding values. But not by default if you download the event and open it.

So it looks like a new feature to add to the app, right? @rodmelia what do you think? shall we provide an estimate?

ifoche commented 3 years ago

only the first 2 or 3 questions already should produce a score, or even without data there are some assign rules (organisation unit: should appear with the ou code & health area: should be assigning the program UID)

ifoche commented 3 years ago

Hi @nancyespinoza . Sorry but we're still unable to reproduce it. I've forwarded you an email with a new apk and the steps we're following, together with a screenshot with this working (here also attached). Could you please let me know after testing with that particular situation to check that it's still not working in that case for you? Screenshot_20210407-113853

nancyespinoza commented 3 years ago

Everything is working as expected with the new apk.

Thank you

nancyespinoza commented 3 years ago

Hi @ifoche! I was able to see the program rules working in the previous apk and with 2.3.2 I cannot longer see them working

PR error

ifoche commented 3 years ago

Hi @nancyespinoza. Looks like the error comes from the compilation of the app. I was apparently pointing to a wrong commit in the rules-engine repository, and that created all this problem. I'm really sorry. Will regenerate a new apk and send it to you asap