EyeSeeTea / dhis2-android-capture-app-psi-fork

PSI fork of official UiO Android app (blessed repository)
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

[2.5.2] Feedback displays empty DEs #28

Closed nancyespinoza closed 1 year ago

nancyespinoza commented 2 years ago

To Reproduce Credentials Server: https://236dev.psi-mis.org User: hnqis2.fork Password: Solar123!

Steps to reproduce the behavior:

  1. Go to HNQIS2 Fork Testing Program
  2. Make a new enrollmetn
  3. Add an Assessment stage
  4. Save the stage and open the feedback
  5. DEs "Section A: Critical" and "Section B: Hidden Section" are shown
  6. Sync the enrollment
  7. Go back to the feedback - they are not shown

Expected behavior

image

Current behavior

image
ifoche commented 2 years ago

Hi @nancyespinoza . After reviewing this, we think that it may not be an error, depending on the reasons to have that specific configuration.

Those DEs have a feedback order set up. If you don't want them in the feedback, is it really needed? Could you just remove the feedback order so they are not shown in the feedback screen?

In case that is needed, then what is happening is that DHIS2 official app sync is removing the null values from the DB. That is why first time you can see it (as it has a feedback order and an null value) and then the sync removes the value so it disappears from the feedback. Our proposal in this case would be to:

Is there any of the options you like more? Do you prefer to wait for our meeting to discuss it?

ifoche commented 2 years ago

We will remove any empty/null value DE from the feedback