search

EyeSeeTea / interpretation-notification

0 stars 0 forks source link

Actions for a user with interpretation R only are including share, edit and delete #16

Closed nancyespinoza closed 5 years ago

nancyespinoza commented 5 years ago

From the interpretation wall it seems that the user is able to edit, delete and share. Once you explore, the only actions available are Like and Reply.

nancyespinoza commented 5 years ago

R only actions (explore).PNG R only actions.PNG

adrianq commented 5 years ago

@rodmelia @nancyespinoza There is a problem with the approach we discussed yesterday. This is what we said:

The main problem is that 'reply' is not working unless the user has 'write permissions' in the interpretation. It is not working for users with 'read permissions'.

You can test this in the maps application. If you go to maps and access an interpretation with 'read permissions' you will be able to see the 'reply' button. However, when you try to submit a comment you get an error because the backend does not allow to create a new comment if you don't have 'write permissions'. This is obviously a bug in DHIS2 and I have no idea what their plans are in this concern. We can still implement what we discussed yesterday but reply for read-only users will not work because of the backend implementation.

rodmelia commented 5 years ago

@adrianq - Let's raise this as a bug in Jira, but please implement based on the agreed design. That means that while interpretations with RO continue not allowing comments, the comment will not save.

tokland commented 5 years ago

Bug created: https://jira.dhis2.org/browse/DHIS2-5760