search

EyeSeeTea / interpretation-notification

0 stars 0 forks source link

Sharing in Interpretation wall showing a UId #7

Closed anamariaelsal closed 5 years ago

anamariaelsal commented 5 years ago

When clicking on the Sharing button in the Interpretation wall, a UId is shown at the top of the pop-up screen. It should not be showing or should be replaced for a more understandable label

nancyespinoza commented 5 years ago

Share interpretations.png

nancyespinoza commented 5 years ago

Adrian, does the "share" button provides permission to the chart/table or just to the interpretation?

adrianq commented 5 years ago

@nancyespinoza this is the behaviour of the DHIS2 component. We are reusing the component you can also find in the new maps app: image

This component uses the displayname of the interpretation. See -> https://leap.psi-mis.org/api/interpretations/LjwAIAay2xI.json We can try to change it but it will take some time and will only work for PSI Interpretation app. For instance, we can maybe use the chart/table name plus the author of the interpretation or something along these lines...

The share button in the interpretation app changes permission for the interpretation itself. Actually, if you try to add a user or user group that is not part of the chart/table it will trigger a validation error