EyeSeeTea / pictureapp

Mobile application designed to report cases of malaria (to a DHIS2 server)
GNU General Public License v3.0
4 stars 4 forks source link

Avoid saving values when survey is open in review mode: #2425

Closed xurxodev closed 5 years ago

xurxodev commented 5 years ago

:pushpin: References

:tophat: What is the goal?

:gear: branches

app: Origin: maintenance/change_keyboard_in_soft_login_to_numeric Target: v1.4_connect bugshaker-android: Origin: downgrade_gradle_version EyeSeeTea-sdk: Origin: Development

:memo: How is it being implemented?

The lost values are values of child questions because change logic is fired when to assign value in parent . This logic remove child values on save parent process.

I have modified DynamicTabAdapter to avoid saving values when the survey is open in review modeand after loading all values and if is multi-question tab then I deactive review mode

:boom: How can it be tested?

Use Case 1: Create different combinations of surveys and click on cancel button in review screen to go back to the survey in review mode, any value should not be lost.

:floppy_disk: Requires DB migration?

:art: UI changes?