EyeSeeTea / pictureapp

Mobile application designed to report cases of malaria (to a DHIS2 server)
GNU General Public License v3.0
4 stars 4 forks source link

Remove unused dbflow-sqlcipher dependency: #2436

Closed xurxodev closed 5 years ago

xurxodev commented 5 years ago

:pushpin: References

:gear: branches

app: Origin: maintenance/support_64-bit-architectures Target: v1.4_connect bugshaker-android: Origin: downgrade_gradle_version
EyeSeeTea-SDK: Origin: development

:tophat: What is the goal?

Support 64-bit architectures

:memo: How is it being implemented?

According to Android documentation https://developer.android.com/distribute/best-practices/develop/64-bit, to support 64-bit architectures your apk should include 64-bit versions of native C/C++ code o libraries if exists native code.

I have analyzed the APK and the dbflow-sqlcipher dependency (version 3) included native code only for 32-bits but I think these library is not using .

I have removed this dependency and native code disappear from apk.

I have tested the 32-bit app version and the 64-bit version and seems to work correctly

:boom: How can it be tested?

UseCase 1: Execute the app normally (32-bit version) and the app should work (pull, push, create surveys etc..)

UseCase 2: generate apk and install on 64-bit supported device executing adb install --abi arm64-v8a YOUR_APK_FILE.apk and the app should work (pull, push, create surveys etc..)

:floppy_disk: Requires DB migration?

:art: UI changes?