Crash when the attacking network doesn't cover all nodes

EyeofBeholder-NLeSC / orange3-argument

Argument analysis, mining, and visualization add-on for Orange3.

https://research-software-directory.org/software/orange3-argument-add-on

Apache License 2.0

2 stars 1 forks source link

Crash when the attacking network doesn't cover all nodes #17

Closed jiqicn closed 1 year ago

jiqicn commented 1 year ago

To reproduce

Load the example dataset
Set edge threshold to 50
click 'mine' button
link the output to the explorer widget

Cause

In the set_positions method of the explorer widget, the coordinates of the nodes are computed by calling the selected layoutting function of the networkx instance, which is created by the edge table. In case that table doesn't cover all the nodes, those not included will not be assigned coordinates, thus no positions to be added.

jiqicn commented 1 year ago

Proposal: add both edge and node table to the graph instance, this will make sure that all nodes will be assigned coordinates, even for nodes without any link to them.

jiqicn commented 1 year ago

This bug is caused by the inf weights of edges, which is due to the way of normalizing weight values. For now, I changed that to be a simple max normalization, but we may want to recompute the weights from the beginning, that is to scale the edge weights to be in [0, 1] scale in miner.