search

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
82 stars 41 forks source link

UDP transport sendto blocking when using hostname #103

Open ovv opened 6 years ago

ovv commented 6 years ago

Using the subscribe client example with a hostname as srv_host (sip.example.com) the call to transport.send_to blocked and not packets are sent.

https://github.com/Eyepea/aiosip/blob/master/aiosip/protocol.py#L24

Not sure if that's something on my side, aiosip side or else.

vodik commented 6 years ago

Yeah, its a thin wrapper around socket.sendto which expects an actual address relevant to the given socket family. DNS resolution will have to happen separately.

https://docs.python.org/3/library/socket.html#socket.socket.sendto

ovv commented 6 years ago

I believe passing a hostname is authorized.

A pair (host, port) is used for the AF_INET address family, where host is a string representing either a hostname in Internet domain notation like 'daring.cwi.nl' or an IPv4 address like '100.50.200.5', and port is an integer.

https://docs.python.org/3/library/socket.html#socket-families

But it's probably a bug on my laptop since it's working fine on TCP. Just wanted to have it here in the slim chance it's not and someone else stumble on it.