Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
83 stars 43 forks source link

Provide the original message to the dialplan #109

Closed vodik closed 6 years ago

vodik commented 6 years ago

Probably should just expose the message rather than parts of it, as one might need more information when deciding how to handle new traffic. For example, holes in the current API: access to the uri, to header, contact header, and potentially extension headers.

codecov-io commented 6 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          15       15           
  Lines        1528     1528           
  Branches      264      264           
=======================================
  Hits         1083     1083           
  Misses        328      328           
  Partials      117      117
Impacted Files Coverage Δ
aiosip/application.py 71.81% <ø> (ø) :arrow_up:
aiosip/dialplan.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92eea1e...dedf7d9. Read the comment docs.

vodik commented 6 years ago

I've left method as its convenient and not to break too much at once. I really doubt anyone is using the username field.

ovv commented 6 years ago

If we go the route of the Dialplan like this we should ask ourselves what should and should not to be available in the resolver. For now that's ok for me.

vodik commented 6 years ago

@ovv agreed.