search

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
82 stars 41 forks source link

Application cleanup #113

Closed ovv closed 6 years ago

ovv commented 6 years ago

Imrpove application cleanup. This might need another pass after #112 is merged

Issue #91 #92

This also add a timeout argument to dialog.request

codecov-io commented 6 years ago

Codecov Report

Merging #113 into master will increase coverage by 2.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #113     +/-   ##
=========================================
+ Coverage   71.52%   73.62%   +2.1%     
=========================================
  Files          15       15             
  Lines        1531     1547     +16     
  Branches      265      267      +2     
=========================================
+ Hits         1095     1139     +44     
+ Misses        319      298     -21     
+ Partials      117      110      -7
Impacted Files Coverage Δ
aiosip/dialog.py 77.89% <100%> (+4.39%) :arrow_up:
aiosip/application.py 77.27% <100%> (+5.46%) :arrow_up:
aiosip/peers.py 74.13% <0%> (+0.77%) :arrow_up:
aiosip/utils.py 66.66% <0%> (+2.56%) :arrow_up:
aiosip/transaction.py 66.21% <0%> (+5.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 850b6bf...cb6159d. Read the comment docs.

vodik commented 6 years ago

Looks good to me.

vodik commented 6 years ago

So the tag gets added as part of the inbound processing? Okay, I think that might should be okay. Might be a little surprising if you dump the message as you don't see the original message anymore, but should be okay.